Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tinyxml2 instead of tinyxml #185

Closed
felixf4xu opened this issue May 19, 2023 · 3 comments · Fixed by #186
Closed

Use tinyxml2 instead of tinyxml #185

felixf4xu opened this issue May 19, 2023 · 3 comments · Fixed by #186

Comments

@felixf4xu
Copy link
Contributor

felixf4xu commented May 19, 2023

Hi,

I'm trying to compile ros2 from source on Windows 11 and urdfdom is the only repo that I need to change the code manually.

The reason is the dependency of "tinyxml" and I really hope "tinyxml2" should be used.

Reason:

  • Tinyxml is not maintained for 10 years
  • Tinyxml uses catkin which is not usually used in ROS2
  • Tinyxml2 is another popular project and its main purpose is to replace the outdated tinyxml

When I check the code and issues, I found that the current branch of [scpeters/tinyxml2] (https://github.com/ros/urdfdom/tree/scpeters/tinyxml2) did exactly what I wanted and it also provides a cmake option to be back compatible (which I don't think is necessary, though)

So, please merge the branch and say goodbye to tinyxml.

@felixf4xu felixf4xu changed the title Merge branch of scpeters/tinyxml2 Use tinyxml2 instead of tinyxml May 19, 2023
@uilianries
Copy link

The TinyXML project is abandoned, and the latest release is from 2011 (https://sourceforge.net/projects/tinyxml/files/tinyxml/). Please, consider updating to TinyXML-2, it's a well maintained project and with frequent releases.

@chging
Copy link

chging commented Oct 25, 2023

i have the same question, why not use tinyxml2

@scpeters
Copy link
Contributor

scpeters commented Dec 6, 2023

this will be fixed by #186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants