fix: ignore defined_value_getter_type if return Future #100
+16
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ignore
defined_value_getter_type
lint if return Future type.Copilot Summary
Details
This pull request primarily addresses two files in the
nilts
andnilts_test
packages, introducing support for asynchronous functions in theDefinedValueGetterType
lint rule and updating theMainButton
class to align with these changes. The most significant changes are the addition of a check forFuture
return types in the lint rule and the introduction ofFuture
return type functions in theMainButton
class.Lint Rule Changes:
packages/nilts/lib/src/lints/defined_value_getter_type.dart
: Updated theDefinedValueGetterType
lint rule to include a check for Dart'sFuture
return type. This change allows the lint rule to correctly handle asynchronous functions.MainButton Class Changes:
packages/nilts_test/test/lints/defined_value_getter_type.dart
: AddedFuture<int> Function()
as a possible type foronReturnPressed
,onFutureReturnPressed
,onNullableReturnPressed
, andonNullableFutureReturnPressed
in theMainButton
class. This change ensures that the class can handle asynchronous functions that return anint
. [1] [2] [3]Feature type