Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore defined_value_getter_type if return Future #100

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

ronnnnn
Copy link
Owner

@ronnnnn ronnnnn commented Feb 24, 2024

Overview

Ignore defined_value_getter_type lint if return Future type.

Copilot Summary

Details

This pull request primarily addresses two files in the nilts and nilts_test packages, introducing support for asynchronous functions in the DefinedValueGetterType lint rule and updating the MainButton class to align with these changes. The most significant changes are the addition of a check for Future return types in the lint rule and the introduction of Future return type functions in the MainButton class.

Lint Rule Changes:

MainButton Class Changes:

Feature type

  • Lint Rule
  • Quick fix
  • Assist
  • Other (Update docs, Configure CI, etc...)

@ronnnnn ronnnnn added the bug Something isn't working label Feb 24, 2024
@ronnnnn ronnnnn changed the title fix: ignore defined_value_getter_type if return Furure fix: ignore defined_value_getter_type if return Future Feb 24, 2024
@ronnnnn ronnnnn merged commit c3467c3 into main Feb 24, 2024
5 checks passed
@ronnnnn ronnnnn deleted the fix-defined_value_getter_type-when-future branch February 24, 2024 02:57
@github-actions github-actions bot mentioned this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant