Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Use .proto files to define CodedInputStream format #77

Open
hanabi1224 opened this issue Jun 11, 2019 · 3 comments
Open

[Suggestion] Use .proto files to define CodedInputStream format #77

hanabi1224 opened this issue Jun 11, 2019 · 3 comments

Comments

@hanabi1224
Copy link
Contributor

I saw the library depends on Google.Protobuf, but it's not using .proto files to define/spec binary format, just curious what's the concern here. :)

@richardschneider
Copy link
Owner

It's technical debt and perhaps my bias not to have another step in building the library.

In Peer Talk I went with protobuf-net which uses C# attributes.

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Jun 12, 2019

Currently it's quite simple to setup the build step of .proto files, and it's actually my another question that why the library depends on both official protobuf and protobuf-net? Any chance to unify them? : )

To setup build step with official protobuf, just add below lines to .csproj

<ItemGroup>
    <Protobuf Include="**/*.proto" />
    <EmbeddedResource Include="**/*.proto" />
    <PackageReference Include="Google.Protobuf" Version="3.8.0" />
    <PackageReference Include="Grpc.Tools" Version="1.21.0" PrivateAssets="All" />
</ItemGroup>

@hanabi1224
Copy link
Contributor Author

Just created a draft PR to unify protobuf dependencies richardschneider/peer-talk#37 Please let me know your concern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants