Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show user if config migration is needed for their own config or for an extends #21456

Open
Tracked by #16359
HonkingGoose opened this issue Apr 12, 2023 · 0 comments
Open
Tracked by #16359
Labels
core:config Related to config capabilities and presets priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)

Comments

@HonkingGoose
Copy link
Collaborator

What would you like Renovate to be able to do?

Rescuing a good idea from getting lost in the discussion. 😄 Source:

Right now, Renovate shows a log message when there's an extends that needs migrating:

 WARN: Config needs migrating
       "originalConfig": {
         "username": "...",
         "gitAuthor": "...",
         "requireConfig": "optional",
         "onboarding": false,
         "platform": "github",
         "includeForks": true,
         "extends": ["github>org/presets"],
         "hostRules": [{"hostType": "docker"}]
       },
       "migratedConfig": {
         "username": "...",
         "gitAuthor": "...",
         "requireConfig": "optional",
         "onboarding": false,
         "platform": "github",
         "includeForks": true,
         "extends": ["github>org/presets"],
         "hostRules": [{"hostType": "docker"}]
       }

It's not immediately clear to the user that the extends part is causing the problem:

I've worked it out that it's that inside the extends there's a includeForks: true that needs migrating.

Would be good if we can try and highlight that it may be an extends that's at fault in this case, as it could be confusing - maybe in the case that originalConfig == migratedConfig?

If you have any ideas on how this should be implemented, please tell us here.

@rarkins said:

I think we should differentiate between "YOUR config needs migrating" (which is actionable) versus "An extends you depend on needs migrating" (which may not be actionable)

Is this a feature you are interested in implementing yourself?

No

@HonkingGoose HonkingGoose added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started core:config Related to config capabilities and presets labels Apr 12, 2023
@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:config Related to config capabilities and presets priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

3 participants
@rarkins @HonkingGoose and others