Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move config migration PR creation to the main repository worker flow #16736

Closed
Tracked by #16359
Gabriel-Ladzaretti opened this issue Jul 24, 2022 · 2 comments
Closed
Tracked by #16359

Move config migration PR creation to the main repository worker flow #16736

Gabriel-Ladzaretti opened this issue Jul 24, 2022 · 2 comments
Assignees
@Gabriel-Ladzaretti
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code

Comments

@Gabriel-Ladzaretti
Copy link
Collaborator

Describe the proposed change(s).

In the current state, we cant use repository cache in the migration flow.
This is because the cache is set before the finalize flow which contains the migration, therefore we cant cache the migration branch.

related discussion in:
@Gabriel-Ladzaretti Gabriel-Ladzaretti added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code status:ready status:in-progress Someone is working on implementation labels Jul 24, 2022
@Gabriel-Ladzaretti Gabriel-Ladzaretti self-assigned this Jul 24, 2022
@Gabriel-Ladzaretti Gabriel-Ladzaretti mentioned this issue Jul 24, 2022
Closed
6 tasks
@HonkingGoose HonkingGoose mentioned this issue Jul 25, 2022
Open
23 tasks
@rarkins
Copy link
Collaborator

rarkins commented Jul 10, 2023 •
edited
Loading

@Gabriel-Ladzaretti is this still an issue? Can you expand on the description if so - I'm not sure I understand it. It is the last one left in #16359

@Gabriel-Ladzaretti
Copy link
Collaborator Author

This one is obsolete.

It was related to an issue we had when running config migration when the repo wasnt being cloned during a run.
Related discussion #16664.

superseded and fixed by -

@Gabriel-Ladzaretti Gabriel-Ladzaretti closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Gabriel-Ladzaretti Gabriel-Ladzaretti

Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:refactor Refactoring or improving of existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move repository/config-migration to the main worker flow Gabriel-Ladzaretti/renovate
2 participants
@rarkins @Gabriel-Ladzaretti