Hex improvements #1070
Hex improvements #1070
Conversation
| <<"== ", Vsn/binary>> -> | ||
| [{Dep, Vsn} | DepsListAcc]; | ||
| <<"==", Vsn/binary>> -> | ||
| [{Dep, Vsn} | DepsListAcc]; |
There was a problem hiding this comment.
These should ideally handle any number of spaces.
|
This should also handle |
|
I'd like to keep |
|
Agreed. @Licenser but this can't be merged as is, you ended up with a bunch of other commits in this. |
|
I've added warnings when packages dependences can not be compiled so there are no quiet failures |
|
@tsloughter you will make me rebase again will you? |
Licenser
force-pushed
the
hex-improvements
branch
from
20bd8c1 to
699a01a
Compare
Add more version constraints Allow for any number of whitespaces after compairison opperator Improve updating and error printing Fix failing tests
Licenser
force-pushed
the
hex-improvements
branch
from
699a01a to
e9e6265
Compare
| rm_ws(R) -> | ||
| R. | ||
|
|
||
| valid_vsn(Vsn) -> |
There was a problem hiding this comment.
Do we really need this? @ferd opinion?
|
@tsloughter regarding to @ericmj there can be no or as many spaces as people want in the requirements. |
Okay. Checked today how many packages rely on this, currently there are 169 packages with |
|
That is odd none of them showed up when updating the registry, with the latest patch all 'incompatible' package should have been printed (tests say it works :P), perhaps rebar pre-filters those since they are not rebar-buildable? On a site node, does't |
Yes, they would all be elixir packages because I think rebar currently only allows published dependencies with strict version requirements. But I think the plan is to allow less strict version requirements and also support elixir projects through plugins. You are right though, support for those operators are not currently needed.
|
|
I'm accepting this. We'll obviously want refinements in the future. |
Add:
==,>=,>,<and<=