change detection of valid modules for eunit
#1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`beam_lib:chunks(..)` needs a path to object code which, frustratingly, `code:which/1` won't return for cover compiled modules. instead just assume that if `code:which/1` doesn't return `non_existing` a module is something we can run tests on
|
That does seem reasonable. +1. |
ferd
added a commit
that referenced
this pull request
Jan 17, 2016
change detection of valid modules for `eunit`
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
beam_lib:chunks(..)needs a path to object code which, frustratingly,code:which/1won't return for cover compiled modules. instead justassume that if
code:which/1doesn't returnnon_existinga moduleis something we can run tests on
fixes #1014