-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: Tab bar implementation #92
Comments
@tristangodfrey I tried this approach by creating a Router component inside a View, but I don't know how to access my 2 routers's toRoute() or toBack() functions.. Were you able to work it out? |
@skizzo This is roughly how I solved it, just a bunch of snippets but it should give you the general idea
|
I will need this feature soon, I'll look it in a few days and I'll be back with a feedback. Using method of Thanks for the snippets @tristangodfrey. |
As a quick "fix" in our fork we just ended up exposing the methods directly: mojotech@7d268d7 And in a stripped down for demo our router w/ tabbar follows similarly to your example
|
Thanks @cpjolicoeur , should we document this approach/add an example or just leave this issue up for reference? Would be happy to contribute if needed. |
we'd want @charpeni and other's opinions on it. Exposing the methods (or a minimal subset of methods) works fine for us. I never formally submitted a Pull Request back to the mainline project with those changes as I didn't know if it was something they were interested in. But maybe a discussion is in order on it. |
I think it's a great idea to expose these methods.
@tristangodfrey It would be appreciate 😃 @SEthX Any thoughts? |
I'll submit a PR with our exposing changset for review/discussion. |
That was fast! |
@tristangodfrey Does the documentation is still in planning? |
If I wrap Router by View then nothing appears on the screen. |
I'm not quite sure how I should implement a tab bar to allow navigation between a small group of routes.
Should I achieve this by nesting a
Router
inside of the main router? So I'll have a singletab-router
route, which loads my tab-bar + router component. Or is there a better way of doing this?The text was updated successfully, but these errors were encountered: