fix: Exclude headers from iOS archive. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mohammadalijf Can you verify that this works for you? Thanks 😄 |
|
I manually tested moving the headers from |
Closed
krizzu
approved these changes
Apr 15, 2019
|
Thanks, everyone ❤️ |
krizzu
pushed a commit
that referenced
this pull request
Apr 15, 2019
## [1.3.3](v1.3.2...v1.3.3) (2019-04-15) ### Bug Fixes * Exclude headers from iOS archive. ([#77](#77)) ([562452c](562452c))
|
🎉 This PR is included in version 1.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Corey-Peyton
added a commit
to Corey-Peyton/async-storage
that referenced
this pull request
Jul 14, 2021
## [1.3.3](react-native-async-storage/async-storage@v1.3.2...v1.3.3) (2019-04-15) ### Bug Fixes * Exclude headers from iOS archive. ([#77](react-native-async-storage/async-storage#77)) ([562452c](react-native-async-storage/async-storage@562452c))
DenisSolution
pushed a commit
to DenisSolution/React-native-async-storage
that referenced
this pull request
Aug 27, 2022
## [1.3.3](react-native-async-storage/async-storage@v1.3.2...v1.3.3) (2019-04-15) ### Bug Fixes * Exclude headers from iOS archive. ([#77](react-native-async-storage/async-storage#77)) ([562452c](react-native-async-storage/async-storage@562452c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
iOS headers are being included in the final archive, making Xcode generate generic archives instead of IPAs. Moving the headers to project only should address this issue. See #76.
Test Plan:
In an app that manually links to AsyncStorage, archiving should generate an IPA and not a generic archive.