Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix broken stats accumulation for 'MeanStdFilter' connector. #49718

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RLlib] Fix broken stats accumulation for 'MeanStdFilter' connector. #49718

wants to merge 1 commit into from

Conversation

duburcqa
Copy link
Contributor

@duburcqa duburcqa commented Jan 8, 2025

Why are these changes needed?

Statistics accumulation for 'MeanStdFilter' is currently broken.

Related issue number

Closes #49716

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(
    • It works on my machine

@jcotant1 jcotant1 added the rllib RLlib related issues label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@simonsays1980 simonsays1980 Awaiting requested review from simonsays1980 simonsays1980 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
rllib RLlib related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib] 'MeanStdFilter' connector is broken.
2 participants
@duburcqa @jcotant1