Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix end-to-end warning url #5126

Merged
merged 2 commits into from
Jan 24, 2020
Merged

Fix end-to-end warning url #5126

merged 2 commits into from
Jan 24, 2020

Conversation

btotharye
Copy link
Contributor

Proposed changes:

  • Change the warning message in the rasa/core/training/dsl.py file for the ValueError on end-to-end testing to be the proper updated doc link.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@btotharye btotharye requested a review from wochinge January 24, 2020 12:48
@btotharye btotharye changed the base branch from master to 1.6.x January 24, 2020 12:48
@btotharye
Copy link
Contributor Author

I know this might be overkill with the changelog and stuff just trying to learn the new process :)

wochinge
wochinge approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks!

@btotharye btotharye merged commit 0d28264 into 1.6.x Jan 24, 2020
@btotharye btotharye deleted the url_fix branch January 24, 2020 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btotharye @wochinge