-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add function to add frequently confused intent to intent report #4899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool feature 👍
One test with a very small confusion matrix (already there) and one with sth like 5x5 would be great
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
thanks @wochinge ! can you please have another quick look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Left a couple of stylistic comments, but otherwise good to go 🚀
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
Co-Authored-By: Tobias Wochinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one more comment, but this is now ready to go 👍
Co-Authored-By: Tobias Wochinger <[email protected]>
Proposed changes:
Adds extra info to the
intent_report.json
created byrasa test
. Specifically, a key is added to the dict which contains up to 2 other intents with high numbers in the confusion matrix.Needs tests and types and general polish
output looks like this:
Status (please check what you already did):
black
(please check Readme for instructions)