Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components (Dropdown, Dialog, etc) are too slow due to Passive effects. #2356

Closed
hywook4 opened this issue Aug 22, 2023 · 7 comments
Closed

Comments

@hywook4
Copy link

hywook4 commented Aug 22, 2023

Hi

When the page size is big (many DOMs), components such as Dropdown/Dialog becomes very slow.

I've used React profiler to dive deep into this issue and found that it's due to long Passive effects.

Below is the screenshot of the profiler result
Screen Shot 2023-08-22 at 5 16 07 PM

I've found that in the case of the Dropdown component, the issue was fixed when I gave modal={false} props.

Also seems like the "Presence" component is the main cause for the passive effects.

Thank you,

@hywook4
Copy link
Author

hywook4 commented Aug 22, 2023

This is just a guess, but
Presence key=".0" seems like the one causing the problem while I have no idea where it came from.

@recurrence
Copy link

Does anyone have a patch for this? Radix SCREAMS in comparison with modal false but it has other unintended consequences.

@hariangr
Copy link

Anyone have any lead on this?

@tangye1234
Copy link

tangye1234 commented Feb 1, 2024

This issue basically is the biggest flaw in this project at present, and no one has come forward to resolve it yet.

@taoliujun
Copy link

When modal is enabled, popover calls the react-remove-scroll component, which iterates through every element in the page, and when there are enough elements, there are performance issues.

But I don't know how to solve it.

@benoitgrelard
Copy link
Contributor

Let's concentrate on a single issue rather than have lots of duplicates for the same thing: #1634

@ibanlopez
Copy link

Let's concentrate on a single issue rather than have lots of duplicates for the same thing: #1634

How is the concentration going?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants