-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components (Dropdown, Dialog, etc) are too slow due to Passive effects. #2356
Comments
This is just a guess, but |
Does anyone have a patch for this? Radix SCREAMS in comparison with modal false but it has other unintended consequences. |
Anyone have any lead on this? |
This issue basically is the biggest flaw in this project at present, and no one has come forward to resolve it yet. |
When modal is enabled, popover calls the react-remove-scroll component, which iterates through every element in the page, and when there are enough elements, there are performance issues. But I don't know how to solve it. |
Let's concentrate on a single issue rather than have lots of duplicates for the same thing: #1634 |
How is the concentration going? |
Hi
When the page size is big (many DOMs), components such as Dropdown/Dialog becomes very slow.
I've used React profiler to dive deep into this issue and found that it's due to long Passive effects.
Below is the screenshot of the profiler result
I've found that in the case of the Dropdown component, the issue was fixed when I gave modal={false} props.
Also seems like the "Presence" component is the main cause for the passive effects.
Thank you,
The text was updated successfully, but these errors were encountered: