Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider bundling helm-ls #3

Open
siegenthalerroger opened this issue Jun 6, 2024 · 2 comments
Open

Consider bundling helm-ls #3

siegenthalerroger opened this issue Jun 6, 2024 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@siegenthalerroger
Copy link

It would be preferable for me to have the extension come bundled with the language server. This would make it easier to have a helm development environment defined purely within the vscode config files. Currently making a portable helm "ide" requires using a devcontainer with helm-ls installed.

@qvalentin
Copy link
Owner

I already thought about this, but was not 100% sure how to approach it.

Bundling binaries for multiple architectures would make the extension quite large.
Otherwise you could have the extension download the binary on startup.

Feel free to look into it (maybe we can just find some other extension and copy their solution).

@siegenthalerroger
Copy link
Author

siegenthalerroger commented Jun 6, 2024

Just went on a deep dive of how the go extension solves this and it is by downloading the go tools upon activation.

https://github.com/golang/vscode-go/blob/master/extension/src/goMain.ts#L119-L120

However they did run in to some issues regarding antivirus detection of dynamically downloaded executables and from the look of things they ended up bundling the tools into the extension (golang/vscode-go#3186).

Another extension that I know the language server isn't some form of webassembly or direct ts/js would be the java tools by redhat. I know they download the JRE but not sure if the jdt-ls is bundled or also dynamically downloaded.

@qvalentin qvalentin added help wanted Extra attention is needed good first issue Good for newcomers labels Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants