Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with React 18 #435

Open
tolokoban opened this issue Apr 23, 2022 · 3 comments
Open

Not compatible with React 18 #435

tolokoban opened this issue Apr 23, 2022 · 3 comments
Labels
bug dependencies Pull requests that update a dependency file help wanted
Milestone

Comments

@tolokoban
Copy link

First of all, I love this package!
It works fine with React 17.0.2, but cannot compile with React 18.0.0

We get this error message:

node_modules/markdown-to-jsx/dist/index.d.ts:53:73 - error TS2694: Namespace 'React' has no exported member 'Props'.

53         createElement: (tag: Parameters<CreateElement>[0], props: React.Props<any>, ...children: React.ReactChild[]) => JSX.Element;
                                                                           ~~~~~
@Chris112
Copy link

Quick bandaid to get around the build error is to add "skipLibCheck": true to your tsconfig

@tolokoban
Copy link
Author

Good to know. Thanks!

@quantizor
Copy link
Owner

Oh hmm, I guess they must have changed the types. We can fix it for v8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file help wanted
Projects
None yet
Development

No branches or pull requests

3 participants