Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PackageFinder caching mechanism #9084

Open
xavfernandez opened this issue Nov 1, 2020 · 1 comment
Open

Refactor PackageFinder caching mechanism #9084

xavfernandez opened this issue Nov 1, 2020 · 1 comment
Labels
type: refactor Refactoring code

Comments

@xavfernandez
Copy link
Member

I’m a bit concerned this may cause some subtle bugs someday if we do change one of the instance variables and forgot to consider the cache. Would it be better to extract the logic into a pure function (outside of the class) and cache that instead?

Originally posted by @uranusjr in #9078 (comment)
@xavfernandez xavfernandez added the type: refactor Refactoring code label Nov 1, 2020
@Martinn1996
Copy link

This looks like a nice issue that ThijmenL98 and I want to work on.

@Martinn1996 Martinn1996 mentioned this issue Mar 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract logic from find_best_candidate and find_all_candidate to static methods Martinn1996/pip
2 participants
@xavfernandez @Martinn1996