From 6eda2fef6c3f78cb344d1f432165846f12a5bca6 Mon Sep 17 00:00:00 2001 From: Michael Bridgen Date: Fri, 9 Sep 2022 15:49:28 +0100 Subject: [PATCH] Avoid deletion with foreground policy in test Foreground propagation propagation relies on a finalizer, which interacts with the operator's finalizer in such a way that prevents deletion indefinitely and for tests to time out (I'm not sure exactly why to be honest, that's just what I observe). It shouldn't be necessary, since the test code in question goes on to wait for the deletion to have taken effect anyway. Signed-off-by: Michael Bridgen --- test/stack_controller_test.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/test/stack_controller_test.go b/test/stack_controller_test.go index f647d4f2..5298bdbc 100644 --- a/test/stack_controller_test.go +++ b/test/stack_controller_test.go @@ -144,14 +144,11 @@ var _ = Describe("Stack Controller", func() { AfterEach(func() { By("Deleting left over stacks") - deletionPolicy := metav1.DeletePropagationForeground Expect(k8sClient.DeleteAllOf( ctx, &pulumiv1alpha1.Stack{}, client.InNamespace(namespace), - &client.DeleteAllOfOptions{ - DeleteOptions: client.DeleteOptions{PropagationPolicy: &deletionPolicy}, - }, + &client.DeleteAllOfOptions{}, )).Should(Succeed()) Eventually(func() bool {