-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot install minimap package requiring native functionality/integration/code #411
Comments
So just going to mention real quick, we have had issues with the bundled NPM within PPM have trouble finding newer versions of Visual Studio because it's quite old. Haven't had a chance to read all the details, but did want to mention that further bumps to PPM would help that portion of the issue. But thanks for the report! |
Visual Studio 2019 is the most recent version that I've found to work. 2022 isn't a valid version in ppm's npm |
Is there a link to something tracking that issue more specifically? |
No there is not. Essentially it comes down to our core goals of updating everything. Once we can get the bundled NPM of PPM updated this issue goes away. So it's less an issue and more a compatibility concern. Really I'd think they best way to be made aware of it is changelogs, of seeing that NPM has been bumped. Which I'm pretty sure every release since Although it may be on one of our project boards |
This comment was marked as duplicate.
This comment was marked as duplicate.
@goyalyashpal the issue you are describing here is totally different then where you've made this comment. It'd really likely make the most sense to create your own issue for this. But just to try and get it resolved quickly, keep in mind the error you are seeing is saying directly that the package you are attempting to install requires native modules. Meaning you need to have a C++ build toolkit installed, this means installing Python, and Visual Studio.
Otherwise the error So then the question becomes how did you install Pulsar? Was it from our Website? |
This comment was marked as duplicate.
This comment was marked as duplicate.
@Pysis868 after installing a supported version of Visual Studio did that resolve this issue? |
Keeping the current, modern version since I use it for other projects too. |
@Pysis868 Yeah keeping the up to date version is fine. But it won't be detected just yet with Pulsar. But installing the older version side by side shouldn't cause any issues |
@Pysis868 So we have been able to update Feel free to read into the details over on the pr. Keep in mind these changes will not appear within Pulsar until our PPM is updated, which may happen around 1.109.0, since 1.108.0 already has a possibly breaking PPM change within it (and we like to stagger those if possible). So it'll take some time, but I'll try to keep this issue in mind once we bring those changes into Pulsar itself. |
@confused-Techie did this end up in 1.108 after all? |
@savetheclocktower Thanks for following up. But no, this is not in 1.108.0, but we should make sure to include it within 1.109.0 Since we had the binary renames in this one, the PPM repo had wanted to minimize churn per release to as little as possible. |
@Pysis868 I know this issue is older, did just want to call out if you weren't aware, the related updates are now fully within Pulsar. Thanks for your patience! |
Seemed to be working, had Pulsar 1.1.09, but reinstalled to test. |
What happened?
Compiler tools not found
Packages that depend on modules that contain C/C++ code will fail to install.
Please install Python and Visual Studio to continue.
Run pulsar -p install --check after installing to test compiling a native module.
Pulsar version
1.102.0
Which OS does this happen on?
🪟 Windows
OS details
10 Pro x64 Version 21H2 Build 19044.1889, cygwin 3.3.5-341.x86_64
Which CPU architecture are you running this on?
64-bit(x86_64)
What steps are needed to reproduce this?
pulsar -p install --check
set -x VCINSTALLDIR (gc)
, then step 1 CLI again, exhibits the same problem.Additional Information:
Debugging guide seems not relevant.
A restart of the application, or merely a re-install/-download of the minimap package seems to have succeeded now,
although the check process still seems flawed, to still be improved, and have these keywords exist in the issue for others to find.
Also could the SSL error be explained? Entirely random? I have no network proxies.
The text was updated successfully, but these errors were encountered: