Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Taskbar shortcut doesn't work #228

Closed
ghost opened this issue Mar 5, 2019 · 9 comments
Closed

Taskbar shortcut doesn't work #228

ghost opened this issue Mar 5, 2019 · 9 comments

Comments

@ghost
Copy link

ghost commented Mar 5, 2019

If I make a shortcut in the taskbar with beta 4 nothing happens.

@ghost
Copy link
Author

ghost commented Mar 6, 2019

Just wanted to say that the same thing happens with beta 6

@ghost
Copy link
Author

ghost commented Mar 6, 2019

Also this issue doesn't appear in version 0.5.9

@ghost
Copy link
Author

ghost commented Mar 6, 2019

And also that the cursor will load for a moment when clicking the shortcut

@kontrollanten
Copy link
Collaborator

And it's Windows 7 you are using? Can you describe the steps to reproduce? I'm not a Windows user but I'll try to reproduce it and fix.

@ghost
Copy link
Author

ghost commented Mar 7, 2019

No, I am on windows 10. Steps go like this.

  1. Open Protonmail
  2. Right click icon in taskbar
  3. Click pin to taskbar
  4. Close proton mail
  5. Press icon

Nothing will happen

kontrollanten added a commit that referenced this issue Mar 7, 2019
Shows the application window when clicking on pinned to taskbar icon, when the application has
already been opened.

fix #228
@kontrollanten
Copy link
Collaborator

Thanks for your explanation. I was able to reproduce and fix this in Windows 10. The latest version should have this fixed, please let me know if it works as expected.

@ghost
Copy link
Author

ghost commented Mar 8, 2019

It works, but it kind of pauses for a moment before opening now.

@ghost
Copy link
Author

ghost commented Mar 8, 2019

Like the cursor will become that circle loading thing for a moment before opening. While I feel like this didn't happen before in 0.5.9, I feel like now the pause is a bit annoying but tolerable.

@kontrollanten
Copy link
Collaborator

Thanks for quick response! The Electron API has changed in the latest version, and that's what has changed since 0.5.9. We're actually not doing anything more than listening on the event that gets triggered and then calls window.open(), so I'm not sure what we can do about the pause. But I'll have a look, or maybe @beatplus

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant