Agent adding instance suffix to additional brokerProperties

[kate-goldenring]

Describe the bug

Configuration brokerProperties provides a way for users to supply additional env vars to an akri broker, independent of the ones provided by a discovery handler. They should not be modified with a suffix like ones set by a discovery handler.

The result is that a broker env var provided in the Configuration as RANDOM=value is now mounted as RANDOM_AKRI-DEBUG-ECHO-489660=value instead of staying RANDOM=value. This is done here in the agent:

akri/agent/src/plugin_manager/device_plugin_instance_controller.rs

Line 416 in 66ce8ac

fn cdi_device_to_car(instance_name: &str, device: &cdi::Device) -> ContainerAllocateResponse {

To Reproduce
Install release (old) helm chart with older agent:

helm repo add akri-helm-charts https://project-akri.github.io/akri/
helm install akri akri-helm-charts/akri \
    --set agent.allowDebugEcho=true \
    --set debugEcho.discovery.enabled=true \
    --set debugEcho.configuration.enabled=true \
    --set debugEcho.configuration.brokerPod.image.repository=nginx \
    --set debugEcho.configuration.brokerPod.image.tag=stable-alpine \
    --set debugEcho.configuration.shared=false

Once broker pods are running, get foo device env

kubectl exec -it akri-debug-echo-489660-pod -- /bin/sh -c "printenv | grep RANDOM"
RANDOM=value

Uninstall akri helm uninstall akri

Repeat for dev chart (latest akri):
Install release (old) helm chart with older agent:

helm repo add akri-helm-charts https://project-akri.github.io/akri/
helm install akri akri-helm-charts/akri-dev \
    --set agent.allowDebugEcho=true \
    --set debugEcho.discovery.enabled=true \
    --set debugEcho.configuration.enabled=true \
    --set debugEcho.configuration.brokerPod.image.repository=nginx \
    --set debugEcho.configuration.brokerPod.image.tag=stable-alpine \
    --set debugEcho.configuration.shared=false

Once broker pods are running, get foo device env

kubectl exec -it akri-debug-echo-123456-pod -- /bin/sh -c "printenv | grep RANDOM"
RANDOM_AKRI-DEBUG-ECHO-489660=value