DOM Exception trigger with ButtonDirective afterViewInit

[LoganFievez]

I'm submitting a ... (check one with "x")

[X] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)

<button pButton icon="my-icon "> <!-- the space at the end is intentional -->

Current behavior
An error is trigger when the lifecycle hook afterViewInit is trigger

Expected behavior
No error

Minimal reproduction of the problem with instructions

• Create an icon only button with pButton directive where in the icon section a space char is left

What is the motivation / use case for changing the behavior?

• Help people avoiding hours of debugging just to find a space char ;)

Please tell us about your environment:
Ubuntu 18.04

• Angular version: 10.2.1

• PrimeNG version: 10.0.3

• Browser: all

• Language: all

• Node (for AoT issues): node --version = v14.8.0

Solution

• In domhandler.ts in the static method addMultipleClasses before running element.classList.add(styles[i]); you should test if styles[i] is ok to be added to the classList

[LoganFievez]

Is it not better to split using a regex like this : className.trim().split(/\s+/); because the className could be like this class="class01 class02" (with two spaces in it)

Thanks ;)