Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProvidePrimeng(v19): deprecated APP_INITIALIZER #17042

Closed
luca-peruzzo opened this issue Dec 13, 2024 · 1 comment · Fixed by #17043
Closed

ProvidePrimeng(v19): deprecated APP_INITIALIZER #17042

luca-peruzzo opened this issue Dec 13, 2024 · 1 comment · Fixed by #17043
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
19.0.0.Final

Comments

@luca-peruzzo
Copy link
Contributor

Describe the bug

APP_INITIALIZER is deprecated and no longer works

Environment

angular 19 app

Reproducer

No response

Angular version

19.0.4

PrimeNG version

19.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.11.0

Browser(s)

all

Steps to reproduce the behavior

No response

Expected behavior

No response
@luca-peruzzo luca-peruzzo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 13, 2024
@luca-peruzzo luca-peruzzo mentioned this issue Dec 13, 2024
Merged
@0x426
Copy link

0x426 commented Dec 14, 2024

When using it with Angular SSR, my complete App gets stuck due to providePrimeNG() with the use of APP_INITIALIZER.

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 16, 2024
@mertsincan mertsincan self-assigned this Dec 16, 2024
@mertsincan mertsincan modified the milestones: 18.0.1, 19.0.0.Final Dec 16, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 16, 2024
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 16, 2024
@mertsincan mertsincan linked a pull request Dec 16, 2024 that will close this issue
fix(v19): provideprimeng #17043
Merged
@mertsincan mertsincan removed their assignment Dec 16, 2024
@mertsincan mertsincan moved this from Review to Done in PrimeNG Dec 16, 2024
@mertsincan mertsincan closed this as completed by moving to Done in PrimeNG Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
PrimeNG
Status: Done
Milestone
19.0.0.Final
Development

Successfully merging a pull request may close this issue.

fix(v19): provideprimeng luca-peruzzo/primeng
3 participants
@mertsincan @0x426 @luca-peruzzo