Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://primeng.org/stepper linear - stackblitz not working because of wrong file name #16967

Closed
DanielOberlechner opened this issue Dec 6, 2024 · 4 comments
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone

Comments

@DanielOberlechner
Copy link
Contributor

Describe the bug

https://primeng.org/stepper

Open linear example in stackblitz, and it won't load because the stepper-linear-demo.ts has following content:

import { Component } from '@angular/core';
import { ImportsModule } from './imports';
@Component({
    selector: 'stepper-linear-demo-demo',
    templateUrl: './stepper-linear-demo-demo.html',
    standalone: true,
    imports: [ImportsModule]
})
export class StepperLinearDemo {
}

correct would be:
'./stepper-linear-demo.html',
'stepper-linear-demo'

Environment

stackblitz environemnt

Reproducer

https://stackblitz.com/run?file=src%2Fapp%2Fapp.component.html

Angular version

18

PrimeNG version

17.18.12

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

node 20

Browser(s)

Chrome newest version on macOS

Steps to reproduce the behavior

Open stackblitz example and it won't load because of wrong names of the files.

Expected behavior

The website should load and show example of linear stepper

@DanielOberlechner DanielOberlechner added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 6, 2024
@mertsincan mertsincan added Resolution: Help Wanted Issue or pull request requires extra help and feedback and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 6, 2024
@mertsincan mertsincan added this to the 17.18.13 milestone Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

Due to PrimeNG team's busy roadmap, this issue is available for anyone to work on. Make sure to reference this issue in your pull request. ✨ Thank you for your contribution! ✨

@mertsincan mertsincan moved this to Review in PrimeNG Dec 7, 2024
@DanielOberlechner
Copy link
Contributor Author

I fixed the issue on stackblitz and forked the reposoitory:
https://stackblitz.com/edit/ab7s5gpm-q1eqbneh?file=src%2Fapp%2Fstepper-linear-demo.ts

But not sure how to implement it now on the website. I'm in contact with people on Discord maybe someone will guide me into the right direction.

@Mickael-Martinez
Copy link

Mickael-Martinez commented Dec 7, 2024

If I understand correctly, the StackBlitz is directly generated from the code.

In that specific case, the problem comes from lines 134 and 135 in this file:

https://github.com/primefaces/primeng/blob/17.18.12/src/app/showcase/doc/stepper/lineardoc.ts

selector: 'stepper-linear-demo-demo',
templateUrl: './stepper-linear-demo-demo.html',

(note the double "demo")

@DanielOberlechner
Copy link
Contributor Author

You are right, due to githubs linting I wasn't able to spot the problem right away, I searched before in the right file, but coulnd't find it. I'll fork the repo and create a pull request. Thank you for guiding me into the right direction!

@mertsincan mertsincan added Component: Documentation Issue or pull request is related to Documentation and removed Resolution: Help Wanted Issue or pull request requires extra help and feedback labels Dec 9, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
Status: Done
Development

No branches or pull requests

3 participants