Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old prettier version that does not support new control-flow syntax #15653

Closed
alexciesielski opened this issue May 22, 2024 · 0 comments · Fixed by #15681
Closed

Old prettier version that does not support new control-flow syntax #15653

alexciesielski opened this issue May 22, 2024 · 0 comments · Fixed by #15681
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
17.18.0

Comments

@alexciesielski
Copy link
Contributor

alexciesielski commented May 22, 2024 •
edited
Loading

Describe the bug

Not a bug report. While implementing my recent PR and using the new control-flow syntax I noticed issues in formatting.

It seems that an old version of prettier is installed, which does not correctly support indentation in control-flow syntax which can be seen here.
@alexciesielski alexciesielski added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 22, 2024
@Sinan997 Sinan997 mentioned this issue May 23, 2024
Merged
@cetincakiroglu cetincakiroglu added dependencies Issue or pull request is related to a dependency package Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible dependencies Issue or pull request is related to a dependency package labels May 30, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.0 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
17.18.0
Development

Successfully merging a pull request may close this issue.

Update prettier version for new control flow Sinan997/primeng
2 participants
@alexciesielski @cetincakiroglu