Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TriStateCheckboxComponent: inputId not working #13946

Closed
amgalitzky opened this issue Oct 23, 2023 · 1 comment · Fixed by #13977
Closed

TriStateCheckboxComponent: inputId not working #13946

amgalitzky opened this issue Oct 23, 2023 · 1 comment · Fixed by #13977
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.7.2

Comments

@amgalitzky
Copy link

Describe the bug

on the TriStateCheckbox when you have a label with a for & a TriStateCheckbox with an inputId when clicking on the label it won't toggle the checkbox state it only shows the focus of the checkbox.

Environment

I use "primeng": "^16.2.0",
You can see the bug on your documentation preview:
https://primeng.org/tristatecheckbox#reactive-forms

Reproducer

No response

Angular version

16.2.0

PrimeNG version

16.2.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

19

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@amgalitzky amgalitzky added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 23, 2023
@SoyDiego SoyDiego mentioned this issue Oct 29, 2023
Merged
@SoyDiego
Copy link
Contributor

HI @amgalitzky.
I did a PR solving the problem and updating the docs.
You can check here: #13977

Thanks!

@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 8, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.7.2
Development

Successfully merging a pull request may close this issue.

TriStateCheckbox: Fix problem when click on label and updated docs SoyDiego/primeng
3 participants
@amgalitzky @SoyDiego @cetincakiroglu