Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Multiselect Component Close Button Accessibility Issues - Close Button is empty + Screen Reader reads 'Unlabeled button' #13859

Closed
willmca opened this issue Oct 11, 2023 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@willmca
Copy link
Contributor

willmca commented Oct 11, 2023

Describe the bug

The Multiselect component's close button is not currently passing 508 accessibility tests, because the button is 'empty'. I have attached a screenshot showing the error thrown by WAVE 508 testing tool. For accessibility purposes, button must have content.
multiselect508closebutton

Additionally, when utilizing a screen reader, the button to close the multiselect reads as 'unlabeled button'. This provides a screen reader user no information about what the button does.

Environment

Windows

Reproducer

https://stackblitz.com/edit/primeng-multiselect-demo?file=README.md

Angular version

16.2.1

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.19.0

Browser(s)

No response

Steps to reproduce the behavior

Note - Tools used for accessibility testing are WAVE accessibility evaluation tools browser extension and JAWS Screen Reader

To replicate Empty Button error with WAVE tool:

  1. Navigate to any Multiselect component
  2. Open the panel
  3. Run the WAVE tool, you will see the empty button 508 accessibility error

To replicate Screen Reader reading unlabeled button

  1. Turn on a screen reader
  2. Navigate to any Multiselect component
  3. Open the panel
  4. Use keyboard navigation to focus on the (x) button used to close the panel

Expected behavior

There should not be an error for 'empty button' when running accessibility tests on the component. Additionally, when using a screen reader, the screen reader should provide a description for what the button does when the user focuses on the button.

@willmca willmca added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 11, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 6, 2023
@cetincakiroglu cetincakiroglu self-assigned this Dec 6, 2023
@cetincakiroglu cetincakiroglu added this to the 17.0.0 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
2 participants