Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown selecting disabled option throws error using keyboard arrows #10252

Closed
JanuszMarek opened this issue May 18, 2021 · 0 comments
Closed
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@JanuszMarek
Copy link

JanuszMarek commented May 18, 2021

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://github-y88uxj.stackblitz.io

Current behavior
When some options are disabled and user wants to traverse to next enabled options using arrow down on keyboard an error is thrown in console. This does not occur when pressing arrow up.

Expected behavior
No error

Minimal reproduction of the problem with instructions

  • Prepare SelectItem[] with some disabled items (already done in stackblitz link)
  • Open dropdown
  • Press arrow down on Keyboard
  • Open Console
  • There is an error
    ERROR TypeError: Cannot read property 'disabled' of undefined

Environment

  • Angular version: 9.1.1

  • PrimeNG version: 9.0.5
    Bug occurs also on newest PrimeNg site using 11.4.2

  • Browser: Chrome 90.0.4430.212

  • Language: TypeScript

  • Node (for AoT issues): node --version = v14.16.1

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 18, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jun 4, 2021
@yigitfindikli yigitfindikli added this to the 12.0.0-Final milestone Jun 4, 2021
@yigitfindikli yigitfindikli self-assigned this Jun 4, 2021
@yigitfindikli yigitfindikli added the LTS-PORTABLE Issue's fix will be ported to supported LTS versions label Jun 4, 2021
@yigitfindikli yigitfindikli added LTS-FIXED-11.4.6 and removed LTS-PORTABLE Issue's fix will be ported to supported LTS versions labels Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants