Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Way to Disable Telemetry when using PnPCoreSdk.Instance.GetPnPContext #987

Closed
bk-td opened this issue Oct 7, 2022 · 3 comments
Closed
Assignees
Labels
area: framework ⚙ Changes in the SDK core framework code

Comments

@bk-td
Copy link

bk-td commented Oct 7, 2022

Would love to see the possibility to set DisableTelemetry to true when creating a PnPContext via:

var pnpContext = PnPCoreSdk.Instance.GetPnPContext(csomContext);

@jansenbe jansenbe self-assigned this Oct 7, 2022
@jansenbe
Copy link
Contributor

Also related to #968

@jansenbe jansenbe added the area: framework ⚙ Changes in the SDK core framework code label Oct 13, 2022
@jansenbe
Copy link
Contributor

@bk-td : in PnP Framework pnp/pnpframework#762 was merged. This allows you to, in your app using PnP Framework configure an IPnPContextFactory with the settings you need and use that same IPnPContextFactory for both PnP Core SDK context creation as for getting a PnPContext from a CSOM ClientContext using below approach.

Note: this will appear via the next nightly build of PnP Framework.

var pnpContext = PnPCoreSdk.Instance.GetPnPContext(csomContext, myPnPContextFactory);

Closing this issue, thanks for using PnP Core SDK and providing feedback.

@bk-td
Copy link
Author

bk-td commented Oct 17, 2022

Awesome, thanks, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: framework ⚙ Changes in the SDK core framework code
Projects
None yet
Development

No branches or pull requests

2 participants