From 01f83986ddfc024b54575b61e91fad30923bcda0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wictor=20Wil=C3=A9n?= Date: Tue, 28 Jun 2022 10:12:57 +0200 Subject: [PATCH 1/4] =?UTF-8?q?=F0=9F=9A=91=20Fixed=20an=20issue=20with=20?= =?UTF-8?q?tab=20config?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/generator-teams/CHANGELOG.md | 10 ++++++++++ packages/generator-teams/src/app/GeneratorTeamsApp.ts | 2 +- .../client/{tabName}/{tabReactComponentName}Config.tsx | 3 ++- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/packages/generator-teams/CHANGELOG.md b/packages/generator-teams/CHANGELOG.md index 89af6fc6..a4c395f2 100644 --- a/packages/generator-teams/CHANGELOG.md +++ b/packages/generator-teams/CHANGELOG.md @@ -6,6 +6,16 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +## [*4.0.1*]- <*2022-06-28*> + +### Fixes + +* Fixed an issue with tab configuration + +### Changes + +* Updated dependencies + ## [*4.0.0*]- <*2022-06-23*> ### Added diff --git a/packages/generator-teams/src/app/GeneratorTeamsApp.ts b/packages/generator-teams/src/app/GeneratorTeamsApp.ts index bdd83494..84b4f0dd 100644 --- a/packages/generator-teams/src/app/GeneratorTeamsApp.ts +++ b/packages/generator-teams/src/app/GeneratorTeamsApp.ts @@ -624,7 +624,7 @@ export class GeneratorTeamsApp extends Generator { // if we have added any react based components if (this.options.reactComponents) { Yotilities.addAdditionalDeps([ - ["msteams-react-base-component", "^4.0.0"] + ["msteams-react-base-component", "^4.0.1"] ], this.fs); } diff --git a/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx b/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx index cbdecea2..fb5c8a5b 100644 --- a/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx +++ b/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx @@ -21,8 +21,9 @@ export const <%=tabReactComponentName%>Config = () => { suggestedDisplayName: "<%=tabTitle%>", removeUrl: host + "/<%=tabName%>/remove.html?theme={theme}", entityId: entityId.current + }).then(()=> { + saveEvent.notifySuccess(); }); - app.notifySuccess(); }; useEffect(() => { From b9f1eaf7eb327da94590eff7eeac4dfa9763d770 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wictor=20Wil=C3=A9n?= Date: Tue, 28 Jun 2022 10:23:40 +0200 Subject: [PATCH 2/4] Updated version tag --- packages/generator-teams/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/generator-teams/package.json b/packages/generator-teams/package.json index 3b37b996..afed2143 100644 --- a/packages/generator-teams/package.json +++ b/packages/generator-teams/package.json @@ -1,6 +1,6 @@ { "name": "generator-teams", - "version": "4.0.0", + "version": "4.0.1-preview.1", "description": "Yeoman generator for Microsoft Teams Apps, including support for extending Teams apps to other parts of the Microsoft 365 ecosystem.", "main": "generators/app/index.js", "scripts": { From 80d6c615928dd5115b73518ddcae0cf4e2bd9835 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wictor=20Wil=C3=A9n?= Date: Tue, 28 Jun 2022 10:33:18 +0200 Subject: [PATCH 3/4] =?UTF-8?q?=F0=9F=9A=A8=20Fixed=20linting=20issue?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/client/{tabName}/{tabReactComponentName}Config.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx b/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx index fb5c8a5b..31dec072 100644 --- a/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx +++ b/packages/generator-teams/src/tab/templates/src/client/{tabName}/{tabReactComponentName}Config.tsx @@ -21,7 +21,7 @@ export const <%=tabReactComponentName%>Config = () => { suggestedDisplayName: "<%=tabTitle%>", removeUrl: host + "/<%=tabName%>/remove.html?theme={theme}", entityId: entityId.current - }).then(()=> { + }).then(() => { saveEvent.notifySuccess(); }); }; From d9b87c89dbba3f013c8ed2051c6722f62d559ee0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wictor=20Wil=C3=A9n?= Date: Tue, 28 Jun 2022 10:34:34 +0200 Subject: [PATCH 4/4] =?UTF-8?q?=F0=9F=94=96=204.0.1=20release?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/generator-teams/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/generator-teams/package.json b/packages/generator-teams/package.json index afed2143..6b35190d 100644 --- a/packages/generator-teams/package.json +++ b/packages/generator-teams/package.json @@ -1,6 +1,6 @@ { "name": "generator-teams", - "version": "4.0.1-preview.1", + "version": "4.0.1", "description": "Yeoman generator for Microsoft Teams Apps, including support for extending Teams apps to other parts of the Microsoft 365 ecosystem.", "main": "generators/app/index.js", "scripts": {