Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of text block #6574

Open
harz05 opened this issue Jan 9, 2025 · 6 comments · May be fixed by #6580
Open

Addition of text block #6574

harz05 opened this issue Jan 9, 2025 · 6 comments · May be fixed by #6580

Comments

@harz05
Copy link

harz05 commented Jan 9, 2025

Description of problem-
There's already a way to add a new text block which is simply to click below the text block but when the text block is empty and you try to add a text block by using the dropdown feature, it doesn't get added. It functions as expected when the text block has some content in it(i.e.- new text block can be added through dropdown). Other blocks such as Table,TOC, etc. don't have this issue.

Solution-
Solution is quite straightforward, you would just need to add a functionality that adds new text block even with the dropdown feature(even when the text block is empty).

Video showing the above problem-
Screencast from 07-01-25 11:56:17 PM IST.webm

@stevepiercy
Copy link
Collaborator

Thanks for the report. I both confirmed the issue and agree this would be an improvement. We might relabel this as a bug instead of enhancement, and change its title, if @plone/volto-team and @plone/volto-accessibility Teams agree.

To reproduce, click the circled + icon (Add block button) to get the popup mentioned.

@sneridagh
Copy link
Member

TBH, I think this is a feature. There is even a more straightforward way, which is press the enter key, as you would do in any editor.

@stevepiercy
Copy link
Collaborator

stevepiercy commented Jan 10, 2025

Yes, but if you are a mouser or tapper or otherwise tend to use the + to add any block (except Text of course), then it's annoying that a Text block appears as an option in the popup menu, but when you select it, nothing happens. To me that's a bug. This should be changed to either insert a Text block, or remove Text block from the menu options.

In any case, whether it's a bug or feature, is this something worth working on and would be accepted into core?

@rahul-vyas-dev

This comment was marked as off-topic.

@Abhishek-17h
Copy link
Contributor

I agree with @stevepiercy. If we are allowing users to create a new text block when the current block is empty by pressing the Enter key, it would be good to provide the same functionality through the dropdown menu.

@Abhishek-17h
Copy link
Contributor

I’ll be raising a PR to address this issue shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants