feat: Import relevant slateTable settings for HTML ui-tables #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisagli
requested changes
Sep 9, 2023
Co-authored-by: David Glick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating a Plone page using DraftJS to Slate (via DraftJS -> HTML -> Slate) we do not want to lose table block settings.
So I propose respecting the table settings by evaluating its classes when converting a HTML to a Slate table.
To avoid applying this behavior to "usual" HTML tables (and messing up the default settings for those cases) I propose only to apply this behavior to tables having the classes
ui table.