You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a class is deprecated, I would expect that any calls to methods in that deprecated class should also trigger a deprecation message.
For example, a change that I implemented locally in CallToDeprecatedMethodRule:
if ($classReflection->isDeprecated()) {
$description = $methodReflection->getDeprecatedDescription();
if ($description === null) {
return [sprintf(
'Call to method %s() of deprecated class %s.',
$methodReflection->getName(),
$methodReflection->getDeclaringClass()->getName()
)];
}
return [sprintf(
"Call to method %s() of deprecated class %s:\n%s",
$methodReflection->getName(),
$methodReflection->getDeclaringClass()->getName(),
$description
)];
}
Though maybe this makes more sense as a separate rule within this library, it works well enough for my needs.
The text was updated successfully, but these errors were encountered:
If a class is deprecated, I would expect that any calls to methods in that deprecated class should also trigger a deprecation message.
For example, a change that I implemented locally in
CallToDeprecatedMethodRule
:Though maybe this makes more sense as a separate rule within this library, it works well enough for my needs.
The text was updated successfully, but these errors were encountered: