Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder? What placeholder??? #47

Open
ehem opened this issue Aug 3, 2016 · 2 comments
Open

placeholder? What placeholder??? #47

ehem opened this issue Aug 3, 2016 · 2 comments

Comments

@ehem
Copy link

ehem commented Aug 3, 2016

I've done the NDK portion of the build, but there is no "placeholder" to be found anywhere. Aside from the references in Superuser/README.md and Superuser/Superuser/assets/update-binary I don't see any placeholder binary anywhere.

While I'm at it, why specify attaching to /system/bin/app_process32? 64-bit builds aren't much more complicated and in the near future some devices might choose not to run /system/app/app_process32 (or run it as a restricted user), while /system/bin/app_process64 could remain in service longer. (noticing all userspace on this device is 64-bit binaries now)

@ehem
Copy link
Author

ehem commented Aug 6, 2016

Just in case you hadn't guessed, I'm aware of the stableL branch. The issue is the directions in the README talk about the use of the placeholder, which isn't present in the master branch. Most likely this should be solved by updating the documentation for the master branch.

@lbdroid
Copy link

lbdroid commented Oct 24, 2016

Documentation is out of date. Feel free to submit pull request to update documentation against github.com/seSuperuser (which is now deemed to be upstream repository).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants