From 40618c7a52fc4864ebbe7d909f43dfb6650376c1 Mon Sep 17 00:00:00 2001 From: parmentelat Date: Thu, 29 Nov 2018 12:52:39 +0100 Subject: [PATCH] start of jupyter notebook server on ip adress '0.0.0.0' instead of default '*' which is no longer supported this is probably needed only on a temporary basis see also https://github.com/jupyter/docker-stacks/issues/718 https://github.com/ageron/handson-ml/pull/317/commits --- scripts/nbh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/scripts/nbh b/scripts/nbh index f018968f..e4ed8180 100755 --- a/scripts/nbh +++ b/scripts/nbh @@ -761,7 +761,7 @@ function docker-create-container-for-student-in-course() { STUDENT_uid=$(id -u $student) command="docker create --name $container - -p 8888 + --publish 8888 --user root --env NBAUTOEVAL_LOG=/home/jovyan/work/.nbautoeval -v $STUDENT_course:/home/jovyan/work @@ -774,11 +774,15 @@ function docker-create-container-for-student-in-course() { done # see start-in-dir-as-uid.sh for a note on setting the directories # below + # note that setting the ip here is a workaround + # for a broken jupyter/docker-stacks version around late 2018 + # probably not needed with more recent ones command="$command -e PYTHONPATH=/home/jovyan/modules $COURSE_image start-in-dir-as-uid.sh /home/jovyan $STUDENT_uid jupyter notebook + --ip=0.0.0.0 --no-browser --NotebookApp.notebook_dir=/home/jovyan/work --NotebookApp.token=$jupyter_token