Can i use in assembly level? #83

drony · 2019-02-07T13:10:56Z

when i tried i got this error

aspect file

[Aspect(Scope.Global)]
[Injection(typeof(LoggingAspect))]
[AttributeUsage(AttributeTargets.All, Inherited = false)]
public class LoggingAspect : Attribute

in assembly

[assembly: LoggingAspect()]

4>C:\Users\xxxx\source\Workspaces\xxx\xxx\Abstract\Device.cs(14,21,14,23): warning CS0169: The field 'Device.v2' is never used
4>  AspectInjector: Started for TPS.Hardware.dll
4>  AspectInjector: Assembly has been read.
4>  AspectInjector: Found 0 aspects
4>  AspectInjector: Found 1218 injections
4>  AspectInjector: Processing injections...
4>  AspectInjector: Executing AdviceInlineWeaver...
4>  AspectInjector: Executing AdviceStateMachineWeaver...
4>  AspectInjector: Executing AdviceAroundWeaver...
4>AspectInjector : error AI_ERR0: Processing failure: System.NullReferenceException: Object reference not set to an instance of an object.
4>     at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.MoveBody(MethodDefinition from, MethodDefinition to)
4>     at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.WrapEntryPoint(MethodDefinition unwrapper)
4>     at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.GetOrCreateUnwrapper()
4>     at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.GetNextWrapper()
4>     at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.Execute()
4>     at AspectInjector.Core.Processor.ProcessAssembly(AssemblyDefinition assembly, Boolean optimize)
4>     at AspectInjector.Core.Processor.Process(String assemblyFile, IAssemblyResolver resolver, Boolean optimize)
4>     at AspectInjector.Commands.ProcessCommand.Execute(IReadOnlyList`1 args). Please submit an issue to https://github.com/pamidur/aspect-injector
4>AspectInjector : error AI_FAIL: Aspect Injector processing has failed. See other errors.
5>------ Build started: Project:xxxxx.Test.App, Configuration: Debug x86 ------

The text was updated successfully, but these errors were encountered:

pamidur · 2019-02-07T13:23:19Z

Hi,
I could not reproduce this case. I suspect aspectInjector tries to wrap around method which is not a method somehow (idk, maybe something from COM or p/invoke).
Could you please provide more code so we can see what exactly in the Assembly you're injecting to?

pamidur · 2019-02-07T13:50:40Z

Ok, i found a problem. This is regression issue with abstract and external methods which was already fixed before. I'll fix it soon

pamidur · 2019-02-07T14:11:31Z

fixed in 2.0.3

drony · 2019-02-07T14:14:02Z

I've just updated. but i think there is a problem with static Main function

public object HandleMethod(
[Argument(Source.Instance)] object instance,
[Argument(Source.Name)] string name,
[Argument(Source.Arguments)] object[] arguments,
[Argument(Source.Target)] Func<object[], object> method)
{

instance is null and i handle instance this time application exit immediately

pamidur · 2019-02-07T14:18:37Z

This is by design.
Static methods (like Main() ) don't have this and you'll receive [Argument(Source.Instance)] object instance = null.

You have to check if instance is null and the process it correctly. Btw you can use [Argument(Source.Type)] this is always not-null

drony · 2019-02-07T14:22:37Z

thanks but this is a new errors

6> AspectInjector: Started forxxx.dll
6> AspectInjector: Assembly has been read.
6> AspectInjector: Found 0 aspects
6> AspectInjector: Found 958 injections
6> AspectInjector: Processing injections...
6> AspectInjector: Executing AdviceInlineWeaver...
6> AspectInjector: Executing AdviceStateMachineWeaver...
6> AspectInjector: Executing AdviceAroundWeaver...
6>AspectInjector : error AI_ERR0: Processing failure: System.NotSupportedException: Specified method is not supported.
6> at AspectInjector.Core.Models.PointCut.PickLoadInstruction(TypeReference elemType)
6> at AspectInjector.Core.Models.PointCut.Cast(TypeReference typeOnStack, TypeReference expectedType)
6> at AspectInjector.Core.Fluent.Arrays.SetByIndex(PointCut pc, TypeReference elementType, Int32 index, Action1 value) 6> at AspectInjector.Core.Fluent.Arrays.CreateArray(PointCut pc, TypeReference elementType, Action1[] elements)
6> at AspectInjector.Core.Advice.Weavers.Processes.AdviceWeaveProcessBase1.LoadArgumentsArgument(PointCut pc, AdviceArgument parameter) 6> at AspectInjector.Core.Models.PointCut.Store(VariableDefinition variable, Action1 val)
6> at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.<>c__DisplayClass11_0.b__0(PointCut e)
6> at AspectInjector.Core.Fluent.MethodEditor.Instead(Action1 action) 6> at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.WrapEntryPoint(MethodDefinition unwrapper) 6> at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.GetOrCreateUnwrapper() 6> at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.GetNextWrapper() 6> at AspectInjector.Core.Advice.Weavers.Processes.AdviceAroundProcess.Execute() 6> at AspectInjector.Core.Processor.ProcessAssembly(AssemblyDefinition assembly, Boolean optimize) 6> at AspectInjector.Core.Processor.Process(String assemblyFile, IAssemblyResolver resolver, Boolean optimize) 6> at AspectInjector.Commands.ProcessCommand.Execute(IReadOnlyList1 args). Please submit an issue to https://github.com/pamidur/aspect-injector
6>AspectInjector : error AI_FAIL: Aspect Injector processing has failed. See other errors.
7>------ Build started: Project:xxx, Configuration: Debug Any CPU ------
7> All packages listed in packages.config are already installed.

pamidur · 2019-02-07T14:32:15Z

Do you use unsafe code?
It seems there is some unusual method argument is your code.

drony · 2019-02-07T14:40:37Z

yes unsafe code available

pamidur · 2019-02-07T14:43:13Z

Can I have any sample on there you pass pointers into method as a parameters?

drony · 2019-02-07T14:57:25Z

actually this is a very very large library. i prepare lightweight sample soon as possible.
thanks for your help

drony · 2019-02-07T15:33:34Z

I've recompiled this line from source code:

AspectInjector.Core>Fluent>PointCut.cs

private Instruction PickStoreInstruction(TypeReference parameterType)
{
var elemType = ((ByReferenceType)parameterType).ElementType;

        switch (elemType.MetadataType)
        {
            case MetadataType.Class: return CreateInstruction(OpCodes.Stind_Ref);
            case MetadataType.Object: return CreateInstruction(OpCodes.Stind_Ref);
            case MetadataType.MVar: return CreateInstruction(OpCodes.Stobj, elemType);
            case MetadataType.Var: return CreateInstruction(OpCodes.Stobj, elemType);
            case MetadataType.Double: return CreateInstruction(OpCodes.Stind_R8);
            case MetadataType.Single: return CreateInstruction(OpCodes.Stind_R4);
            case MetadataType.Int64: return CreateInstruction(OpCodes.Stind_I8);
            case MetadataType.UInt64: return CreateInstruction(OpCodes.Stind_I8);
            case MetadataType.Int32: return CreateInstruction(OpCodes.Stind_I4);
            case MetadataType.UInt32: return CreateInstruction(OpCodes.Stind_I4);
            case MetadataType.Int16: return CreateInstruction(OpCodes.Stind_I2);
            case MetadataType.UInt16: return CreateInstruction(OpCodes.Stind_I2);
            case MetadataType.Byte: return CreateInstruction(OpCodes.Stind_I1);
            case MetadataType.SByte: return CreateInstruction(OpCodes.Stind_I1);
            case MetadataType.Boolean: return CreateInstruction(OpCodes.Stind_I1);
            case MetadataType.Char: return CreateInstruction(OpCodes.Stind_I2);
            case MetadataType.UIntPtr: return CreateInstruction(OpCodes.Stind_I);
            case MetadataType.IntPtr: return CreateInstruction(OpCodes.Stind_I);
            case MetadataType.String: return CreateInstruction(OpCodes.Stind_I);
        }

        **throw new NotSupportedException(elemType.MetadataType.ToString());**
    }

here is the missing type: -> String

5> All packages listed in packages.config are already installed.
5> AspectInjector: Started for xxx.dll
5> AspectInjector: Assembly has been read.
5> AspectInjector: Found 0 aspects
5> AspectInjector: Found 42 injections
5> AspectInjector: Processing injections...
5> AspectInjector: Executing AdviceInlineWeaver...
5> AspectInjector: Executing AdviceStateMachineWeaver...
5> AspectInjector: Executing AdviceAroundWeaver...
5>AspectInjector : error AI_ERR0: Processing failure: System.NotSupportedException: String

drony · 2019-02-07T15:35:08Z

and it think add this line should be fix:

case MetadataType.String: return CreateInstruction(OpCodes.Ldind_Ref);

drony · 2019-02-07T16:04:37Z

for my project:

MetadataType.ValueType
MetadataType.GenericInstance
MetadataType.String
MetadataType.Array

missing in pointcut.cs in 2 locations

pamidur · 2019-02-07T16:29:55Z

have a try 2.0.5

drony · 2019-02-08T13:51:12Z

thanks it works

drony changed the title ~~Can i use assembly level?~~ Can i use in assembly level? Feb 7, 2019

pamidur self-assigned this Feb 7, 2019

pamidur added the bug label Feb 7, 2019

pamidur closed this as completed Feb 7, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Can i use in assembly level? #83

Can i use in assembly level? #83

drony commented Feb 7, 2019

pamidur commented Feb 7, 2019

pamidur commented Feb 7, 2019

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019 •

edited

Loading

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019

drony commented Feb 7, 2019

drony commented Feb 7, 2019

drony commented Feb 7, 2019 •

edited

Loading

pamidur commented Feb 7, 2019

drony commented Feb 8, 2019

Can i use in assembly level? #83

Can i use in assembly level? #83

Comments

drony commented Feb 7, 2019

aspect file

in assembly

pamidur commented Feb 7, 2019

pamidur commented Feb 7, 2019

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019 • edited Loading

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019

pamidur commented Feb 7, 2019

drony commented Feb 7, 2019

drony commented Feb 7, 2019

drony commented Feb 7, 2019

drony commented Feb 7, 2019 • edited Loading

pamidur commented Feb 7, 2019

drony commented Feb 8, 2019

drony commented Feb 7, 2019 •

edited

Loading

drony commented Feb 7, 2019 •

edited

Loading