-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Pact Specification v4 #318
Comments
@tienvx is currently working on a migration to the new Rust FFI, which would support this. We should perhaps pin an issue that is being worked on to raise visibility. What do you think @YOU54F ? In the meantime, that PR would probably work if you were open to creating one (I know somebody did something similar for Pact JS a few years ago). |
@mefellows could you tell me what branch(PR) I can use then (there a dozen of them as I see https://github.com/pact-foundation/pact-php/pulls) |
I don't know the branch (hence why I You'd need to test that it actually does anything though, I might be getting my PRs mixed up. I looked at the Pact JS PRs and couldn't find the one I thought. |
Hey, we will be using the @tienvx has split out the PR's at the moment, each one is numbered and builds on the last, #280 would be a good place to start |
Ah I did see that. I'll pin that one for now for visibility, but I realise that there is not much visibility on this repo that there is a mountain of work going on under the hood. We could also perhaps flesh this project board out. |
Current status is listed in #262 (comment) May be worth closing this down to avoid duplication, but TL;DR is you can test this out today in your projects, by checking out the instructions in the above pinned issue 👍🏾 |
I think technically you could make this work with the current version, but it would need somebody to spike/test it (ideally the OP). The ideal solution of course is the proper support for V3/V4 pacts in the referenced issue. |
We've just released an alpha package today with some instructions - HTH https://github.com/pact-foundation/pact-php/releases/tag/10.0.0-alpha1 |
@YOU54F So I can not use common php FFI but use yours pact_ffi ? |
I am installing FFI like
But as I see header file contatns string C++ like string |
alpine isn't supported, with the v10.x branch, I am afraid. If you use a debian slim image, things will be smoother You need the ffi extension, pact-php will take care of loading the library for you. |
just another pointer in code, this is where pact php reads in the header file, and shared lib and this is where phps ffi method is called https://github.com/pact-foundation/pact-php/blob/ffi/src/PhpPact/FFI/Client.php |
Thanks a lot! @YOU54F |
V4 available in v10.x alpha, and mainlined to See compat table https://github.com/pact-foundation/pact-php?tab=readme-ov-file#compatibility fyi alpine support is coming :) #613 |
Hi there,
I am wondering if PHP library is going to support Pact Specification v4 soon?
If it is no, I guess, changing implementation of PhpPact\Consumer\Model\Interaction will help me to send, say, params for providerState (see Example 1):
Example 1:
Thank you!
The text was updated successfully, but these errors were encountered: