Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing env variables information on how to set up PR scanning with GitLeaks #4467

Open
bdovaz opened this issue Jan 8, 2025 · 1 comment · May be fixed by #4478
Open

Missing env variables information on how to set up PR scanning with GitLeaks #4467

bdovaz opened this issue Jan 8, 2025 · 1 comment · May be fixed by #4478
Labels
enhancement New feature or request

Comments

@bdovaz
Copy link
Collaborator

bdovaz commented Jan 8, 2025

The PR by @DariuszPorowski adds this functionality but does not explain in the documentation that the GitleaksLinter.py script requires passing if using Azure DevOps (variables depends on each provider) SYSTEM_PULLREQUEST_SOURCECOMMITID, SYSTEM_PULLREQUEST_TARGETBRANCH environment variables by hand to the Docker container.
@bdovaz bdovaz added the enhancement New feature or request label Jan 8, 2025
@bdovaz
Copy link
Collaborator Author

bdovaz commented Jan 8, 2025 •
edited
Loading

I also see that it requires BUILD_REASON:

megalinter/megalinter/linters/GitleaksLinter.py

Line 33 in 2402a65

if utils.is_azure_devops_pr():

megalinter/megalinter/utils.py

Line 559 in 2402a65

def is_azure_devops_pr() -> bool:

There are functions of the different providers that have been created that require more environment variables:

https://github.com/oxsecurity/megalinter/pull/2504/files#diff-3ca08b9e9fc45018fefa78d8e4f1833be65c748ee208289b393163dab58f127e

@bdovaz bdovaz linked a pull request Jan 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Azure Pipelines instructions to Gitleaks linter oxsecurity/megalinter
1 participant
@bdovaz