Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

messageString is missing the omitempty tag #67

Closed
another-rex opened this issue Sep 17, 2023 · 2 comments · Fixed by #68
Closed

messageString is missing the omitempty tag #67

another-rex opened this issue Sep 17, 2023 · 2 comments · Fixed by #68

Comments

@another-rex
Copy link

messageStrings added in #63 is missing the omitempty tag so it's always showing up in results, e.g.:

"rules": [
  {
    "id": "CVE-123-456",
    "shortDescription": {
      "text": "..."
    },
    "messageStrings": null
  }
]
@owenrumney owenrumney mentioned this issue Sep 18, 2023
Merged
@owenrumney
Copy link
Owner

owenrumney commented Sep 18, 2023 •
edited
Loading

resolved in v2.2.2

@another-rex
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add omitempty annotation to messageStrings owenrumney/go-sarif
2 participants
@owenrumney @another-rex