Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with upgrade to v8.0.1 and Lumen v5.7.1 #447

Closed
mnlm opened this issue Oct 2, 2018 · 5 comments
Closed

Issue with upgrade to v8.0.1 and Lumen v5.7.1 #447

mnlm opened this issue Oct 2, 2018 · 5 comments
Assignees
Labels
bug Issue, error or unexpected behavior V8

Comments

@mnlm
Copy link

mnlm commented Oct 2, 2018

Q A
Bug? yes
New Feature? no
Framework Lumen
Framework version 5.7.1
Package version 8.0.1
PHP version 7.2.10

Actual Behaviour

Upgrade from v7.0.1 to version v8.0.1. Bootstraping the application fails with Error: Call to undefined function OwenIt\Auditing\config_path().

This helper function doesn't exist in the Lumen framework and is used here: https://github.com/owen-it/laravel-auditing/blob/v8.0.1/src/AuditingServiceProvider.php#L39. Change was made in 3a85fcb.

Possible Solutions

Revert back to using base_path().

@quetzyg quetzyg self-assigned this Oct 2, 2018
@quetzyg quetzyg added bug Issue, error or unexpected behavior V8 labels Oct 2, 2018
@quetzyg
Copy link
Contributor

quetzyg commented Oct 2, 2018

Thanks for pointing this out @mnlm.

I think the database_path() helper isn't available either. Can you confirm?

@mnlm
Copy link
Author

mnlm commented Oct 2, 2018

@quetzyg The database_path() helper does exist: https://github.com/laravel/lumen-framework/blob/v5.7.1/src/helpers.php

@quetzyg
Copy link
Contributor

quetzyg commented Oct 2, 2018

Alright, I'll sort this ASAP.

@quetzyg
Copy link
Contributor

quetzyg commented Oct 2, 2018

Fixed in version 8.0.2

@quetzyg quetzyg closed this as completed Oct 2, 2018
@mnlm
Copy link
Author

mnlm commented Oct 2, 2018

Works fine now. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue, error or unexpected behavior V8
Projects
None yet
Development

No branches or pull requests

2 participants