-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form-field): rendering, styling, testing and documenting #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellier
requested changes
Jul 11, 2023
packages/tools/generator/component/_tmp/stencil/src/global.test.ts
Outdated
Show resolved
Hide resolved
CDS Report build#889.0 ✘
|
astagnol
requested changes
Jul 11, 2023
packages/stencil/components/form-field/src/components/osds-form-field/osds-form-field.spec.ts
Outdated
Show resolved
Hide resolved
packages/tools/storybook/stories/components/form-field/form-field.web-components.stories.ts
Outdated
Show resolved
Hide resolved
packages/specifications/components/form-field/specifications-form-field.mdx
Outdated
Show resolved
Hide resolved
packages/specifications/components/form-field/specifications-form-field.mdx
Outdated
Show resolved
Hide resolved
dpellier
requested changes
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to rebase properly on master, as you embed doc changes which were merged already
Leotheluck
force-pushed
the
feat/form-field
branch
from
July 12, 2023 08:07
83a6510
to
7eb1ecf
Compare
dpellier
reviewed
Jul 17, 2023
packages/stencil/components/form-field/src/components/osds-form-field/osds-form-field.scss
Show resolved
Hide resolved
dpellier
reviewed
Jul 17, 2023
packages/stencil/components/form-field/src/components/osds-form-field/osds-form-field.tsx
Outdated
Show resolved
Hide resolved
dpellier
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component: OsdsFormField
A Form Field component is used to wrap several form components with logic, visual hints and additional styling.
Attributes:
// if set, update helper slot with the error message and apply error style
error?: string
flex?: boolean
Usages: