Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(link): set href & target optionnal #61

Merged
merged 3 commits into from
Jun 2, 2023
Merged

fix(link): set href & target optionnal #61

merged 3 commits into from
Jun 2, 2023

Conversation

aesteves60
Copy link
Contributor

No description provided.

@aesteves60 aesteves60 requested a review from a team as a code owner June 1, 2023 09:07
astagnol
astagnol requested changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@astagnol astagnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Can you add a sentence in usage.mdx explaining to users that when they don't add href attribute, osds-link is button-like?

@astagnol astagnol merged commit 4943d84 into master Jun 2, 2023
@astagnol astagnol deleted the fix/link-href branch June 2, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astagnol astagnol astagnol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aesteves60 @astagnol