feat: add circle shape in button #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ady642
commented
May 15, 2023
•
ady642
commented
|
CDS Report build-storybook#467.0 ✘
|
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
from
1a011d3 to
13dee9a
Compare
|
CDS Report build-storybook#481.0 ✘
|
|
CDS Report build-storybook#482.0 ✘
|
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
from
13dee9a to
6b8cfab
Compare
|
CDS Report build-storybook#493.0 ✘
|
|
CDS Report build-storybook#494.0 ✘
|
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
2 times, most recently
from
2084060 to
c500986
Compare
|
CDS Report build-storybook#501.0 ✘
|
ady642
changed the title
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
3 times, most recently
from
91add05 to
b03a03a
Compare
ady642
commented
May 19, 2023
| @@ -23,7 +23,7 @@ export function OdsComponentAttributes2StringAttributes<T>(attributes: OdsCompon | |||
| .map(([name, value]) => { | |||
| if (typeof value === "boolean") { | |||
| if (value) { | |||
| parameters[name] = undefined; | |||
| parameters[name] = "true"; | |||
There was a problem hiding this comment.
with undefined the circle was undefined in the stencil button component during the tests
dpellier
reviewed
May 19, 2023
packages/libraries/core/src/components/button/ods-button-controller.spec.ts
Outdated
Show resolved
Hide resolved
dpellier
reviewed
May 19, 2023
packages/stencil/components/button/src/components/osds-button/styles/osds-button.size.scss
Outdated
Show resolved
Hide resolved
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
from
b03a03a to
e20b96c
Compare
|
CDS Report build-storybook#517.0 ✘
|
dpellier
approved these changes
May 22, 2023
astagnol
reviewed
May 22, 2023
packages/stencil/components/button/src/components/osds-button/osds-button.spec.ts
Outdated
Show resolved
Hide resolved
packages/stencil/components/button/src/components/osds-button/styles/osds-button.size.scss
Outdated
Show resolved
Hide resolved
packages/stencil/components/button/src/components/osds-button/styles/osds-button.size.scss
Outdated
Show resolved
Hide resolved
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
from
9da4abe to
1976eda
Compare
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
from
1976eda to
fc5ac94
Compare
ady642
force-pushed
the
feat/add-circle-attribute-to-button
branch
from
fc5ac94 to
a846d3a
Compare
astagnol
requested changes
May 25, 2023
packages/stencil/components/button/src/docs/osds-button/properties/usage.circle.mdx
Outdated
Show resolved
Hide resolved
packages/stencil/components/button/src/components/osds-button/osds-button.e2e.screenshot.ts
Outdated
Show resolved
Hide resolved
astagnol
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.