Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(datagrid): row change & storybook #288

Merged
merged 3 commits into from
Nov 24, 2023
Merged

fix(datagrid): row change & storybook #288

merged 3 commits into from
Nov 24, 2023

Conversation

aesteves60
Copy link
Contributor

Error on row change: test throx when the fix was not present
Phone-number / Search-bar select cropped

@aesteves60 aesteves60 requested a review from a team as a code owner November 21, 2023 16:45
astagnol
astagnol requested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@astagnol astagnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datagrid is not displayed as expected in usage guidelines when using a Menu with row formatter:
Capture d’écran 2023-11-22 à 10 08 50

It seems there is still a regression from v16.2.1 (Select):
Capture d’écran 2023-11-22 à 10 21 05
Not sure this regression is related to Datagrid though. We can discuss about it

@aesteves60 aesteves60 force-pushed the fix-datagrid-rowchange branch from 3a792fe to 7abfece Compare November 22, 2023 09:51
@aesteves60 aesteves60 merged commit 1bb506e into master Nov 24, 2023
@aesteves60 aesteves60 deleted the fix-datagrid-rowchange branch November 24, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leotheluck Leotheluck Leotheluck approved these changes

@astagnol astagnol astagnol approved these changes

@feoche feoche feoche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aesteves60 @feoche @astagnol @Leotheluck