feat(datepicker): step 3, excluding dates #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellier
requested changes
Sep 28, 2023
| @@ -23,10 +23,17 @@ class OdsDatepickerController { | |||
| if (newValue === undefined || newValue === null || isNaN(newValue.getTime())) { | |||
There was a problem hiding this comment.
you can add also || !this.validateValue(newValue) condition and remove the last else
There was a problem hiding this comment.
Can you create a function for add context like isValidValue
|
|
||
| private validateValue(value?: Date) { | ||
| if (value) { | ||
| if (!this.component.maxDate || this.getMidnightDate(value).getTime() <= this.getMidnightDate(this.component.maxDate).getTime() ) { |
There was a problem hiding this comment.
you should split your validation and avoid calling the same function (getMidnightDate) so many times, more like
if (!value) {
return false;
}
const midnightDate = new Date(Date.UTC(date.getFullYear(), date.getMonth(), date.getDate()))
if (this.component.maxDate) {
return <test max date>
}
if (this.component.minDate) {
return <test max date>
}
...
aesteves60
requested changes
Sep 28, 2023
packages/components/datepicker/src/components/osds-datepicker/core/controller.ts
Outdated
Show resolved
Hide resolved
packages/components/datepicker/src/components/osds-datepicker/core/controller.ts
Outdated
Show resolved
Hide resolved
| @@ -23,10 +23,17 @@ class OdsDatepickerController { | |||
| if (newValue === undefined || newValue === null || isNaN(newValue.getTime())) { | |||
There was a problem hiding this comment.
Can you create a function for add context like isValidValue
| defaultValue: null, | ||
| options: [null, new Date('1999-11-02'), new Date('2024-11-02')], | ||
| }, | ||
| minDate: { |
There was a problem hiding this comment.
I have an error on storybook with the date
And when I select one the input not display the value
aesteves60
requested changes
Sep 28, 2023
packages/components/datepicker/src/components/osds-datepicker/osds-datepicker.tsx
Outdated
Show resolved
Hide resolved
astagnol
requested changes
Sep 28, 2023
astagnol
approved these changes
Oct 2, 2023
aesteves60
approved these changes
Oct 3, 2023
Leotheluck
added a commit
that referenced
this pull request
Oct 3, 2023
* feat(datepicker): step 3, excluding dates * feat(datepicker): step 3, excluding dates
dpellier
pushed a commit
that referenced
this pull request
Oct 4, 2023
* feat(datepicker): step 3, excluding dates * feat(datepicker): step 3, excluding dates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding options to disable specific dates of the Datepicker.
New enum:
ODS_DATEPICKER_DAY: monday = 1, saturday = 6, etc.New attributes: