feat(select): add slot selectedLabel #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skhamvon
force-pushed
the
feat/select-custom-selected-option
branch
3 times, most recently
from
8029fa3 to
4014205
Compare
aesteves60
requested changes
Sep 11, 2023
packages/components/select/src/components/osds-select-option/osds-select-option.tsx
Outdated
Show resolved
Hide resolved
packages/components/select/src/components/osds-select/osds-select.tsx
Outdated
Show resolved
Hide resolved
packages/components/select/src/components/osds-select/osds-select.tsx
Outdated
Show resolved
Hide resolved
packages/components/select/src/components/osds-select/osds-select.tsx
Outdated
Show resolved
Hide resolved
aesteves60
force-pushed
the
feat/select-custom-selected-option
branch
from
a031437 to
3673180
Compare
dpellier
approved these changes
Sep 18, 2023
aesteves60
approved these changes
Sep 18, 2023
astagnol
approved these changes
Sep 18, 2023
aesteves60
added a commit
that referenced
this pull request
Sep 20, 2023
* feat(select): add slot selectedLabel * feat(select): selected label slot in select component * fix(select): fix storybook & doc --------- Co-authored-by: Alexandre Esteves <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODS-877
Add new slot to customize the label of an option once selected