Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(popover): add new component popover #14

Merged
merged 10 commits into from
Jun 27, 2023
Merged

feat(popover): add new component popover #14

merged 10 commits into from
Jun 27, 2023

Conversation

skhamvon
Copy link
Contributor

No description provided.

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 21, 2023

CDS Report build#124.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from d3dc2bd to 264c4e9 Compare March 22, 2023 08:53
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 22, 2023

CDS Report build#128.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 264c4e9 to f20ae7b Compare March 22, 2023 16:11
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 22, 2023

CDS Report build#133.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from f20ae7b to 2f6d92f Compare March 22, 2023 16:30
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 22, 2023

CDS Report build#134.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 2f6d92f to 03af083 Compare March 23, 2023 15:04
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2023

CDS Report build#140.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 03af083 to bff4395 Compare March 23, 2023 16:17
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2023

CDS Report build#142.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from bff4395 to 40af499 Compare March 23, 2023 16:23
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2023

CDS Report build#143.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 40af499 to d289d1d Compare March 23, 2023 16:49
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2023

CDS Report build#145.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from d289d1d to 15529db Compare March 24, 2023 15:56
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build#159.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 15529db to b31e885 Compare March 24, 2023 16:24
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build#164.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from b31e885 to 1164f56 Compare March 24, 2023 16:34
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build#169.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 28, 2023

CDS Report build#178.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 29, 2023

CDS Report build#185.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 29, 2023

CDS Report build#187.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 30, 2023

CDS Report build#189.0 ✘
*

  • build ✘

@astagnol astagnol force-pushed the feat/component-popover-ODS-438 branch from e47f0d4 to 1907fbb Compare March 30, 2023 16:04
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 30, 2023

CDS Report build#191.0 ✘
*

  • build ✘

@astagnol astagnol force-pushed the feat/component-popover-ODS-438 branch from 1907fbb to 98e7b1b Compare March 30, 2023 16:18
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 30, 2023

CDS Report build#192.0 ✘
*

  • build ✘

@astagnol astagnol force-pushed the feat/component-popover-ODS-438 branch from 98e7b1b to 2ac8de6 Compare April 3, 2023 10:49
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 4, 2023

CDS Report build#399.0 ■
*

  • build ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 4, 2023

CDS Report build#400.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 43b5b62 to 353fce3 Compare May 5, 2023 07:59
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 5, 2023

CDS Report build#403.0 ■
*

  • build ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 5, 2023

CDS Report build#403.0 ■
*

  • build ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 5, 2023

CDS Report build#404.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 353fce3 to fba4ede Compare May 5, 2023 08:10
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 5, 2023

CDS Report build#405.0 ■
*

  • build ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 5, 2023

CDS Report build#405.0 ■
*

  • build ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 9, 2023

CDS Report build-storybook#424.0 ✘
*

  • build ✘

@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from cb42a75 to 6f936b7 Compare May 16, 2023 14:40
@skhamvon skhamvon force-pushed the feat/component-popover-ODS-438 branch from 6f936b7 to 6f4a7ba Compare May 23, 2023 09:21
astagnol added 2 commits June 23, 2023 15:21
@astagnol
Merge branch 'master' into feat/component-popover-ODS-438
5621e21 
Signed-off-by: aurore.stagnol <[email protected]>

# Conflicts:
#	packages/libraries/cdk/package.json
#	packages/libraries/core/src/components/public-api.ts
#	packages/libraries/testing/src/components/public-api.ts
#	packages/libraries/theming/size/ods-size-definitions.scss
#	packages/stencil/components/tsconfig.components.dev.json
#	packages/stencil/components/tsconfig.components.prod.json
#	packages/stencil/components/tsconfig.components.test.json
#	packages/stencil/libraries/stencil-testing/package.json
#	yarn.lock
@astagnol
feat(popover): update version & import cmpts in global test
484f60f 
Signed-off-by: aurore.stagnol <[email protected]>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 23, 2023

CDS Report build#764.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Jun 26, 2023

CDS Report build#775.0 ✘
*

  • build ✘

dpellier
dpellier requested changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@dpellier dpellier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding keyboard navigation, I couldn't focus the trigger on the storybook, so impossible to test Enter/Escape behavior

packages/libraries/core/jest.config.ts Outdated Show resolved Hide resolved
packages/libraries/core/src/components/popover/popover/ods-popover-controller.ts Outdated Show resolved Hide resolved
packages/libraries/core/src/components/popover/popover/ods-popover-controller.ts Outdated Show resolved Hide resolved
packages/libraries/core/src/components/popover/popover/ods-popover-controller.ts Show resolved Hide resolved
packages/libraries/core/src/components/popover/popover/ods-popover-controller.ts Show resolved Hide resolved
@astagnol astagnol force-pushed the feat/component-popover-ODS-438 branch from ae5b411 to 52e75ad Compare June 26, 2023 17:01
@astagnol astagnol force-pushed the feat/component-popover-ODS-438 branch from 1d6a053 to 2b7faf0 Compare June 27, 2023 09:57
@astagnol astagnol merged commit 507155c into master Jun 27, 2023
@astagnol astagnol deleted the feat/component-popover-ODS-438 branch June 27, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astagnol astagnol astagnol approved these changes

@dpellier dpellier dpellier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skhamvon @ovh-cds @dpellier @astagnol