Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component.tabs): Add new component tabs #13

Merged
merged 34 commits into from
Apr 20, 2023
Merged

feat(component.tabs): Add new component tabs #13

merged 34 commits into from
Apr 20, 2023

Conversation

aboungnaseng-ovhcloud
Copy link
Contributor

Add new component tabs

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 16, 2023

CDS Report build#108.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 16, 2023

CDS Report build#109.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 21, 2023

CDS Report build#125.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 22, 2023

CDS Report build#129.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 22, 2023

CDS Report build#130.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 22, 2023

CDS Report build#131.0 ✘
*

  • build ✘

astagnol
astagnol requested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@astagnol astagnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, in CSS files, instead of a class you can use :host {} to apply styles for the component
For example in osds-tab-panel.scss
And you also can use some mixins

packages/libraries/core/src/components/tabs/public-api.ts Outdated Show resolved Hide resolved
packages/stencil/components/libraries/stencil-core/src/stencilConfig.js Outdated Show resolved Hide resolved
packages/stencil/components/select/src/index.html Outdated Show resolved Hide resolved
packages/stencil/components/tabs/.stencil/screenshot-cache.json Outdated Show resolved Hide resolved
packages/stencil/components/tabs/src/components/osds-tab-bar-item/osds-tab-bar-item.scss Outdated Show resolved Hide resolved
packages/stencil/components/tabs/src/components/osds-tab-bar-item/osdsTabBarItem.tsx Outdated Show resolved Hide resolved
packages/stencil/components/tabs/src/components/osds-tab-bar-item/osdsTabBarItem.tsx Outdated Show resolved Hide resolved
packages/stencil/components/tabs/stencil.config.ts Show resolved Hide resolved
packages/tools/storybook/stories/components/tabs/tabs.twig.stories.ts Outdated Show resolved Hide resolved
packages/tools/storybook/stories/components/tabs/tabs.twig.stories.page.mdx Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2023

CDS Report build#137.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 23, 2023

CDS Report build#147.0 ✘
*

  • build ✘

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested a review from a team as a code owner March 24, 2023 10:02
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build#151.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 24, 2023

CDS Report build#156.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 27, 2023

CDS Report build-storybook#172.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 27, 2023

CDS Report build-storybook#172.1 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 28, 2023

CDS Report build-storybook#177.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 31, 2023

CDS Report build#193.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 31, 2023

CDS Report build#194.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build#200.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build#201.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build#202.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build#203.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build#204.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build#205.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build#207.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 4, 2023

CDS Report build-storybook#209.0 ✘
*

  • build ✘

stevering
stevering suggested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@stevering stevering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR analyzed and already fixed inside this branch:
feat/tabs-component...feat/tabs-component-fixed

i hope the diff with the fixed version will teach you on what e have todo,
and us on what is missing in contributing doc

packages/design/components/tabs/ design-tabs.mdx Outdated Show resolved Hide resolved
packages/stencil/components/libraries/stencil-core/src/stencilConfig.js Outdated Show resolved Hide resolved
packages/stencil/components/tabs/docs/osds-tabs/properties/usage.checked.mdx Outdated Show resolved Hide resolved
packages/design/components/tabs/ design-tabs.mdx Outdated Show resolved Hide resolved
packages/libraries/core/src/components/tabs/ods-tab-bar/public-api.ts Outdated Show resolved Hide resolved
packages/stencil/components/tabs/src/components/osds-tab-bar/osds-tab-bar.tsx Outdated Show resolved Hide resolved
packages/stencil/components/tabs/src/components/osds-tab-panel/osds-tab-panel.tsx Outdated Show resolved Hide resolved
packages/stencil/components/tabs/src/components/osds-tabs/osds-tabs.e2e.screenshot.ts Outdated Show resolved Hide resolved
packages/stencil/components/tabs/src/components/osds-tabs/osds-tabs.tsx Outdated Show resolved Hide resolved
packages/libraries/core/src/components/tabs/ods-tabs/ods-tabs-controller.ts Show resolved Hide resolved
stevering
stevering suggested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@stevering stevering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR analyzed and already fixed inside this branch:
feat/tabs-component...feat/tabs-component-fixed

i hope the diff with the fixed version will teach you on what e have todo,
and us on what is missing in contributing doc

@aboungnaseng-ovhcloud
feat(component.tabs): init component tabs
26da791 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): create tab-bar-item, tab-bar, tab-panel
21b3965 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): add tab index name with event and listen
f8e4ff8 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
aboungnaseng-ovhcloud and others added 22 commits April 19, 2023 15:15
@aboungnaseng-ovhcloud
feat(component.tabs): add tests ods-tabs e2e
ac87458 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): update tests ods-tabs e2e
a49de17 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): create screenshot tabs
91fb484 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): fix public api in tab core library
27b7a27 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): update component tabs
f6f469a 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): udpate controller and role item tabs
1145c16 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): update style in tab bar item
3d89e1d 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): add stories in stoybook
99baa49 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@stevering @aboungnaseng-ovhcloud
fix(tabs): the lockfile would have been modified
3f3eb6c
@aboungnaseng-ovhcloud
feat(component.tabs): add component tabs in start react vite
c4b2e89 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tab): add react router dom rout
dd04773 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): uncomment starter vite react demo
6f29c7c 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): delete breaddcrumb component
a61cce8 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(components.tabs): delete tabs .stencil
0d8ffa3 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(components.tabs): update package json
f9846ea 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(components.tabs): update resolution type react
c651b44 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): update tabs doc
3dd160c 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): update package json resolve package
e04b678 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@aboungnaseng-ovhcloud
feat(component.tabs): update yarn lock
a5fb551 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
@stevering @aboungnaseng-ovhcloud
fix(tabs): fix codestyle and architecture of code
d9fdfd2
@stevering @aboungnaseng-ovhcloud
fix(tabs): fix testing
4d1e1e8
@stevering @aboungnaseng-ovhcloud
fix(tabs): fix codestyle and architecture of code
12ee322
@aboungnaseng-ovhcloud
fix(component.tabs): delete unuse png file
8a31636 
ref: MANAGER-10948

Signed-off-by: Alex Boungnaseng <[email protected]>
stevering
stevering approved these changes Apr 19, 2023
View reviewed changes
packages/stencil/components/tabs/src/components/osds-tab-panel/osds-tab-panel.scss Outdated
@@ -0,0 +1,3 @@
.tab-panel {
padding: 1rem;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove as in the XD

packages/design/assets/design-images/tabs/tabs-screen.png Outdated Show resolved Hide resolved
@stevering stevering requested a review from astagnol April 19, 2023 15:31
@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 19, 2023

CDS Report build-storybook#250.0 ✘
*

  • build ✘

@stevering stevering merged commit e73b220 into master Apr 20, 2023
@stevering stevering deleted the feat/tabs-component branch April 20, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevering stevering stevering approved these changes

@astagnol astagnol astagnol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aboungnaseng-ovhcloud @ovh-cds @astagnol @stevering