fix(input): set cursor to not-allowed when disabled #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpellier
requested changes
Jul 18, 2023
Leotheluck
force-pushed
the
fix/input-pointer-events
branch
from
8befdd3 to
2996012
Compare
dpellier
reviewed
Jul 18, 2023
| @include osds-input-on-selected-host() { | ||
| opacity: .5; | ||
| cursor: not-allowed; | ||
| pointer-events: none; |
There was a problem hiding this comment.
is this what has been asked for? cause this now allows user to select content on disabled input which was not doable before
There was a problem hiding this comment.
goal was to display cursor as not allowed but not be able to interact with the input (which is enabled by the native disabled attribute of it)
dpellier
approved these changes
Jul 18, 2023
aesteves60
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component input should have cursor to not-allowed when disabled, and pointer-events shouldn't be accessible (in this case, the native input has disabled attribute which disables native pointer-events, prioritizing cursor in the styling)