Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component.pagination): Add new component pagination #10

Merged
merged 51 commits into from
May 23, 2023
Merged

feat(component.pagination): Add new component pagination #10

merged 51 commits into from
May 23, 2023

Conversation

Kranysys
Copy link
Contributor

No description provided.

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 16, 2023

CDS Report build#101.0 ✘
*

  • build ✘

@Kranysys Kranysys force-pushed the feat/pagination-component branch from 2c9eab8 to 1a4ff0e Compare March 17, 2023 09:06
@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 17, 2023

CDS Report build#114.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 17, 2023

CDS Report build#118.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 20, 2023

CDS Report build#120.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 20, 2023

CDS Report build#123.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Apr 28, 2023

CDS Report build-storybook#323.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build#329.0 ■
*

  • build ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build#329.0 ■
*

  • build ■

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build-storybook#330.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build-storybook#330.1 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build-storybook#330.2 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build-storybook#332.0 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build-storybook#332.1 ✘
*

  • build ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented May 2, 2023

CDS Report build-storybook#349.0 ✘
*

  • build ✘

@Kranysys Kranysys requested a review from stevering May 3, 2023 15:16
astagnol
astagnol requested changes May 9, 2023
View reviewed changes
Copy link
Contributor

@astagnol astagnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found out that in libraries/core/src/components/pagination, public.api does not export ods-pagination-mock, is that normal?

Since master has been updated, you need to update your branch with master and then, you'll have to do like I did to fix Tabs component on master. Check this PR: https://github.com/ovh/design-system/pull/34/files

packages/libraries/core/src/components/pagination/ods-pagination-default-attributes.ts Outdated Show resolved Hide resolved
packages/stencil/components/pagination/src/components/osds-pagination/osds-pagination.spec.ts Show resolved Hide resolved
packages/libraries/core/src/components/pagination/ods-pagination-current-change-event-detail.ts Show resolved Hide resolved
packages/stencil/components/pagination/src/components/osds-pagination/osds-pagination.spec.ts Show resolved Hide resolved
packages/stencil/components/pagination/src/components/osds-pagination/osds-pagination.e2e.ts Outdated Show resolved Hide resolved
packages/stencil/components/pagination/src/components/osds-pagination/osds-pagination.e2e.ts Outdated Show resolved Hide resolved
packages/stencil/components/pagination/src/components/osds-pagination/osds-pagination.e2e.ts Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 10, 2023

CDS Report build-storybook#432.0 ✘
*

  • build ✘

@Kranysys Kranysys requested a review from astagnol May 11, 2023 14:45
@Kranysys
Copy link
Contributor Author

you have to refactor some things and once it is done, you will see with the team how to teach you on the tests

Done @stevering , waiting approuval of the pull request

@Kranysys
Copy link
Contributor Author

I found out that in libraries/core/src/components/pagination, public.api does not export ods-pagination-mock, is that normal?

Since master has been updated, you need to update your branch with master and then, you'll have to do like I did to fix Tabs component on master. Check this PR: https://github.com/ovh/design-system/pull/34/files

Done @astagnol, waiting approuval of the pull request

@Kranysys Kranysys requested review from aboungnaseng-ovhcloud and removed request for astagnol May 16, 2023 15:23
@Kranysys Kranysys requested a review from astagnol May 22, 2023 08:24
@astagnol astagnol dismissed stevering’s stale review May 23, 2023 08:52

requested changes OK, need to merge

@astagnol astagnol merged commit 3b4c767 into master May 23, 2023
@astagnol astagnol deleted the feat/pagination-component branch May 25, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astagnol astagnol astagnol approved these changes

@skhamvon skhamvon Awaiting requested review from skhamvon

@feoche feoche Awaiting requested review from feoche

@stevering stevering Awaiting requested review from stevering

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud Awaiting requested review from aboungnaseng-ovhcloud

Assignees

@feoche feoche

@Kranysys Kranysys

@astagnol astagnol

@stevering stevering

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Kranysys @ovh-cds @feoche @astagnol @stevering @aboungnaseng-ovhcloud