Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adbkit-apkreader getting wrong fields from AndroidManifest #17

Closed
IvoVentura opened this issue Sep 26, 2018 · 4 comments
Closed

adbkit-apkreader getting wrong fields from AndroidManifest #17

IvoVentura opened this issue Sep 26, 2018 · 4 comments

Comments

@IvoVentura
Copy link

Good morning,

We are having issues with this plugin, it is reading the information of the AndroidManifest.xml incorrectly.

Instead of grabbing the package name it's grabbing the platformBuildVersionName instead.

We have an open issue on the google-play-vsts-extension regarding this issue. You have on there the manifest we are using plus the execution result of the adbkit-apkreader.

Best Regards

@sorccu
Copy link
Member

sorccu commented Sep 26, 2018

I need the APK file, or you can extract and send just the binary manifest from the .apk file. If you can also provide the XML manifest, that would be great. Note though that the XML manifest is not enough by itself, I really need the binary version too. Email to simo at openstf dot io.

@IvoVentura
Copy link
Author

Hi @sorccu,

I'll send you the apk and xml via email.

Thanks for the help,
Best Regards

@sorccu sorccu closed this as completed in 46eea0f Sep 26, 2018
@sorccu
Copy link
Member

sorccu commented Sep 26, 2018

Should be fixed now in v3.1.0. The issue was the the manifest's string pool referred to the same string a few times, which confused the string parser. Haven't encountered that behavior before.

@IvoVentura
Copy link
Author

@sorccu It's working fine now.
Thank you so much for your assistance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants